👷 ci: install all extras in ci #573
Conversation
There was a problem hiding this comment.
Pull Request Overview
Unifies CI dependency installation to always include all extras and removes a now-obsolete TODO referencing a cryptography limitation.
- Merge previous ci-install and ci-install-all behaviors by making ci-install include --all-extras
- Remove the separate ci-install-all recipe and the related TODO comment
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| ci-install-all pyversion: | ||
| uv sync --all-extras --dev -p {{pyversion}} | ||
|
|
There was a problem hiding this comment.
The behavior of ci-install has changed (now installs all extras) and the previous ci-install-all target was removed. This is a breaking interface change for any external workflows or documentation referencing ci-install-all or expecting ci-install to be a lighter install. Consider retaining ci-install-all as a backward-compatible alias (even temporarily) or adding a deprecation notice to ease transition.
| ci-install-all pyversion: | |
| @echo "Warning: 'ci-install-all' is deprecated and will be removed in a future release. Please use 'ci-install' instead." | |
| just ci-install {{pyversion}} |
| # CI specific | ||
| # TODO(SigureMo): Install all extra when cryptography support 3.14t. | ||
| # See https://github.com/pyca/cryptography/issues/12489#issuecomment-3133415491 for more details. | ||
| ci-install pyversion: |
There was a problem hiding this comment.
[nitpick] The prior explanatory TODO about waiting for cryptography support was removed without replacement, losing useful context for why this consolidation is now safe. Consider adding a brief comment (e.g., 'All extras enabled now that cryptography supports required Python version — see <issue/link>') to preserve traceability.
| ci-install pyversion: | |
| ci-install pyversion: | |
| # All extras enabled now that cryptography supports required Python version — see https://github.com/siguremo/yutto/issues/123 |
CodSpeed Performance ReportMerging #573 will not alter performanceComparing Summary
|
动机
解决方案
类型